Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edu SA Arrows Guide: Version 2.000 added #7434

Closed
wants to merge 1 commit into from
Closed

Edu SA Arrows Guide: Version 2.000 added #7434

wants to merge 1 commit into from

Conversation

simoncozens
Copy link
Collaborator

Taken from the upstream repo https://github.com/SorkinType/SASchoolHandAustralia at commit SorkinType/SASchoolHandAustralia@d15e85c.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
  • Minisite_url definition in the METADATA.pb file for commissioned projects
  • Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@github-actions GitHub Actions
Copy link

FontBakery report

fontbakery version: 0.12.0a4

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] EduSAArrowsGuide[wght].ttf
ℹ️ **INFO** METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]

All other checks

[19] EduSAArrowsGuide[wght].ttf
⚠️ **WARN** Font has correct post table version?
  • ⚠️ WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]
⚠️ **WARN** Check if OS/2 xAvgCharWidth is correct.
  • ⚠️ WARN OS/2 xAvgCharWidth is 1188 but it should be 1129 which corresponds to the average of the widths of all glyphs in the font. [code: xAvgCharWidth-wrong]
ℹ️ **INFO** List all superfamily filepaths
  • ℹ️ INFO ofl/edusaarrowsguide [code: family-path]
⚠️ **WARN** Check accent of Lcaron, dcaron, lcaron, tcaron

  • ⚠️ WARN Lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]

  • ⚠️ WARN dcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]

  • ⚠️ WARN lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]

  • ⚠️ WARN tcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]

⚠️ **WARN** Check math signs have the same width.
  • ⚠️ WARN The most common width is 951 among a set of 2 math glyphs.
    The following math glyphs have a different width, though:

Width = 1020:
plus

Width = 1019:
equal, notequal

Width = 1025:
plusminus

Width = 832:
multiply

Width = 840:
divide, minus

Width = 1027:
approxequal

Width = 1033:
lessequal, greaterequal
[code: width-outliers]

ℹ️ **INFO** Font contains all required tables?

  • ℹ️ INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp

    • vhea

    • vmtx [code: optional-tables]

🔥 **FAIL** Whitespace glyphs have ink?

  • 🔥 FAIL Glyph 'space' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni00A0' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni2000' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni2001' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni2002' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni2003' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni2004' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni2005' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni2006' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni2007' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni2008' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni2009' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni200A' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni200B' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni202F' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

  • 🔥 FAIL Glyph 'uni205F' has ink. It needs to be replaced by an empty glyph. [code: has-ink]

⚠️ **WARN** Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: ĭ i̇ ǐ i̒ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ ĵ j̆ j̇ j̊

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Ijo, Southeast (Latn, 2,471,000 speakers), Nzakara (Latn, 50,000 speakers), Mfumte (Latn, 79,000 speakers), Mango (Latn, 77,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Avokaya (Latn, 100,000 speakers), Sar (Latn, 500,000 speakers), Basaa (Latn, 332,940 speakers), Koonzime (Latn, 40,000 speakers), South Central Banda (Latn, 244,000 speakers), Gulay (Latn, 250,478 speakers), Ma’di (Latn, 584,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Bete-Bendi (Latn, 100,000 speakers), Ebira (Latn, 2,200,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Dii (Latn, 71,000 speakers), Makaa (Latn, 221,000 speakers), Ejagham (Latn, 120,000 speakers), Navajo (Latn, 166,319 speakers), Nateni (Latn, 100,000 speakers), Fur (Latn, 1,230,163 speakers), Lugbara (Latn, 2,200,000 speakers), Southern Kisi (Latn, 360,000 speakers), Yala (Latn, 200,000 speakers), Zapotec (Latn, 490,000 speakers), Igbo (Latn, 27,823,640 speakers), Mundani (Latn, 34,000 speakers), Dan (Latn, 1,099,244 speakers), Bafut (Latn, 158,146 speakers), Aghem (Latn, 38,843 speakers), Ekpeye (Latn, 226,000 speakers), Kom (Latn, 360,685 speakers), Dutch (Latn, 31,709,104 speakers), Cicipu (Latn, 44,000 speakers). [code: soft-dotted]

⚠️ **WARN** Check for codepoints not covered by METADATA subsets.

  • ⚠️ WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, canadian-aboriginal, tifinagh

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, coptic, tifinagh, math

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+0307 COMBINING DOT ABOVE: try adding one of: coptic, math, tifinagh, malayalam, canadian-aboriginal, syriac, tai-le, old-permic

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
    37 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu [code: unreachable-subsetting]

🔥 **FAIL** Shapes languages in all GF glyphsets.
  • 🔥 FAIL GF_Latin_Core glyphset:
Language FAIL messages
nl_Latn (Dutch) Shaper didn't attach acutecomb to J
^ Shaper didn't attach acutecomb to j

[code: failed-language-shaping]

ℹ️ **INFO** Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ **INFO** EPAR table present in font?
ℹ️ **INFO** Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ️ **INFO** Show hinting filesize impact.
  • ℹ️ INFO Hinting filesize impact:
ofl/edusaarrowsguide/EduSAArrowsGuide[wght].ttf
Dehinted Size 509.1kb
Hinted Size 509.1kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
⚠️ **WARN** Is there kerning info for non-ligated sequences?

  • ⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • glyph00147 + glyph00154

    • glyph00154 + glyph00167 [code: lacks-kern-info]

⚠️ **WARN** Are there caret positions declared for every ligature?
  • ⚠️ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
⚠️ **WARN** Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ **INFO** Font has old ttfautohint applied?
  • ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000'] [code: version-not-detected]
⚠️ **WARN** Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479) [code: bad-hhea-range]
[1] Family checks
ℹ️ **INFO** Check axis ordering on the STAT table.

  • ℹ️ INFO None of the fonts lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 10 45 9 181 0
0% 0% 1% 4% 18% 4% 73% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal self-requested a review March 27, 2024 16:47
@simoncozens simoncozens mentioned this pull request Mar 28, 2024
Open
26 tasks
@vv-monsalve vv-monsalve requested review from m4rc1e and removed request for emmamarichal March 28, 2024 19:14
@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label Apr 10, 2024
@vv-monsalve
Copy link
Collaborator

Closing all the Edu SA superfamily open PRs now. Please feel free to reopen them when the family is ready for review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4rc1e m4rc1e Awaiting requested review from m4rc1e

Assignees
No one assigned
Labels
-- Needs Upstream Resolution Upstream fix required before moving forward I New Font
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simoncozens @vv-monsalve